Skip to content

feat(node): validator reward skeleton implementation#1165

Closed
cryptoAtwill wants to merge 92 commits intoraulk/prototype-rewardsfrom
skeleton-validator-rewards
Closed

feat(node): validator reward skeleton implementation#1165
cryptoAtwill wants to merge 92 commits intoraulk/prototype-rewardsfrom
skeleton-validator-rewards

Conversation

@cryptoAtwill
Copy link
Copy Markdown
Contributor

@cryptoAtwill cryptoAtwill commented Oct 7, 2024

This PR extends #1162 with the following:

  • Implemented the validator reward distribution flow in the parent subnet. Instead of adding directly to the subnet storage, this PR uses library and facet to make reward distribution more modular.
  • Added a metadata field to validator summary for extra data required.
  • Added ValidatorActivityTracker trait fendermint so that the implementation can decide how to track validator's activity.
  • Implemented a solidity contract based ValidatorActivityTracker, only contract is implemented at the moment.

Todos:

  • Gather initial feedbacks on this approach.
  • Adding integration for ValidatorActivityTracker and solidity contracts.
  • Tests

cryptoAtwill and others added 30 commits May 31, 2024 00:14
Co-authored-by: Eric Tu <6364934+ec2@users.noreply.github.com>
Co-authored-by: Mikers <snissn@gmail.com>
Co-authored-by: raulk <raul@protocol.ai>
Co-authored-by: Shashank Trivedi <100513286+lordshashank@users.noreply.github.com>
Co-authored-by: Karel Moravec <moravec.wdd@gmail.com>
Co-authored-by: Karel Moravec <moravec.wdd@gmail.com>
Co-authored-by: raulk <raul@protocol.ai>
@cryptoAtwill cryptoAtwill requested a review from a team as a code owner October 7, 2024 10:12
@cryptoAtwill cryptoAtwill marked this pull request as draft October 7, 2024 10:12
@raulk
Copy link
Copy Markdown
Contributor

raulk commented Oct 22, 2024

Integrated into #1181.

@raulk raulk closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants